refactor: adopt template helper for 1 simple eejsBlock_* hook(s)#94
Merged
Conversation
Replaces 1 hand-rolled
exports.eejsBlock_X = (hookName, args, cb) => {
args.content += eejs.require('plugin/template.ejs');
cb();
};
block(s) with the canonical template() call from ep_plugin_helpers.
Same runtime behavior — eejs renders the same template into the
same section. Removes per-plugin re-implementation of args.content
+= eejs.require(...) boilerplate.
Only converts the strictly-simple shape; hooks with vars,
conditional logic, or non-eejs content (e.g. raw <script> tags) are
left alone — those need the helper's vars/skip callbacks or stay
hand-rolled. Part of Phase 4 of the modernization campaign.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the
template()helper fromep_plugin_helpersfor 1eejsBlock_*hook(s) that match the strict-simple shape:Replaced with:
Same runtime behavior — eejs renders the same template into the same section. The helper just removes per-plugin re-implementation of the
args.content += eejs.require(...)boilerplate.Out of scope
Hooks with vars, conditional skip logic, or non-eejs content (e.g. raw
<script>tags being concatenated) are left alone — those need either the helper'svars/skipcallbacks or different helper variants. Part of Phase 4 of the modernization campaign (pilot: ether/ep_align#182, ether/ep_themes#103).